verify /dev/mem is not present in QM partition #495
Conversation
pengshanyu
requested review from
rhatdan,
lsm5,
dougsland,
Yarboa,
odra,
sandrobonazzola,
dennisbrendel and
priyverm
as code owners
|
/packit test --identifier e2e-ffi |
|
will improve it based on the review of the design |
|
/packit test --identifier e2e-multi-bluechi-agents |
pengshanyu
force-pushed
the
dev-mem-not-accessible
branch
from
e14dfe2 to
558db73
Compare
|
please squash commits for easy review. |
|
@dougsland @Yarboa thank you so much for the review. |
|
#495 (comment) |
pengshanyu
changed the title
|
Sorry for the confusion caused by the comment above. |
pengshanyu
force-pushed
the
dev-mem-not-accessible
branch
2 times, most recently
from
86216e9 to
7afe651
Compare
|
Just a general comment: this is not a special property of |
pengshanyu
force-pushed
the
dev-mem-not-accessible
branch
from
496f62a to
abf9583
Compare
pengshanyu
force-pushed
the
dev-mem-not-accessible
branch
from
09c5ae8 to
3f68c61
Compare
Signed-off-by: pengshanyu <[email protected]> add a single newline Signed-off-by: pengshanyu <[email protected]> remove -i and -a option Signed-off-by: pengshanyu <[email protected]> change test name Signed-off-by: pengshanyu <[email protected]> use test -e to check if file exists Signed-off-by: pengshanyu <[email protected]> remove output redirection Signed-off-by: pengshanyu <[email protected]> replace hyphen with low-line Signed-off-by: pengshanyu <[email protected]>
pengshanyu
force-pushed
the
dev-mem-not-accessible
branch
from
d0bb53d to
7f40a32
Compare
Signed-off-by: pengshanyu <[email protected]>
| @@ -0,0 +1,10 @@ | |||
| Verifies that /dev/mem is not present in QM partition. | |||
There was a problem hiding this comment.
Please send another patch later using this format below, I will unblock you for now.
@pengshanyu. Thanks! Also, your commit message container several duplicate signed-off-by (SOB) next time please remove the dup lines.
Title:
Foobar 123 123
Description:
Foobar 123 123
Input:
Foobar 123 123
Expected Result:
Foobar 123123
Jira:
Foobar 123123
There was a problem hiding this comment.
Hi @dougsland, sorry, I didn't notice them. Sure, I'll pay attention next time. Thanks.
There was a problem hiding this comment.
Not your fault at all, we are starting to create it ;-)
I want ensure that /dev/mem is not accesible inside QM partition.
Test Design (improved based on PR review):
Using test expression in QM partition:
Execute the following command:
podman exec qm test -e /dev/memExpected Result:
/dev/mem does not exist, the command returns a non-zero value
Verify whether the test passed or not:
PASS: if the command returns a non-zero value, it means /dev/mem is not present
FAIL: if the command returns 0, it means /dev/mem is present