-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide users to install huggingface-cli to login to huggingface #645
Conversation
Reviewer's Guide by SourceryThis pull request adds a note to the documentation that the huggingface-cli tool is required to login to huggingface. It also adds a link to the huggingface documentation on how to install and use the tool. Sequence diagram for Huggingface login flowsequenceDiagram
actor User
participant CLI as Ramalama CLI
participant HF as huggingface-cli
participant Hub as Huggingface Hub
User->>CLI: ramalama login --token=XYZ huggingface
Note over CLI: Requires huggingface-cli
CLI->>HF: Use huggingface-cli
HF->>Hub: Authenticate with token
Hub-->>HF: Authentication response
HF-->>CLI: Authentication result
CLI-->>User: Login status
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pbabinca - I've reviewed your changes - here's some feedback:
Overall Comments:
- The link format contains an extra parenthesis - please change
]: (https...
to]: https...
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Thanks @pbabinca |
Might need to do a squash also, a problem with committing the bots suggestions in the web ui, is the bot can't sign a commit under someones name. |
CI also complained we use invalid syntax in the docs, we need to fix that:
|
Well, this is tricky. I thought of providing link to documentation and locally the change rendered correctly:
This one suggest use of brackets by
I haven't found external hyperlinks in ramalama nor podman so I'm not sure what would be preferred way to make CI happy. Do you have any suggestions how to approach this? |
docs/ramalama-login.1.md
Outdated
@@ -49,9 +49,11 @@ Login to huggingface registry | |||
``` | |||
$ ramalama login --token=XYZ huggingface | |||
``` | |||
Logging in to Hugging Face requires the `huggingface-cli` tool. For installation and usage instructions, see the [documentation of Command Line Interface (CLI) of Hub Python Library on Hugging Face]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging in to Hugging Face requires the `huggingface-cli` tool. For installation and usage instructions, see [*documentation of Command Line Interface (CLI) of Hub Python Library on Hugging Face*].
docs/ramalama-login.1.md
Outdated
|
||
## SEE ALSO | ||
**[ramalama(1)](ramalama.1.md)** | ||
[documentation of Command Line Interface (CLI) of Hub Python Library on Hugging Face]: (https://huggingface.co/docs/huggingface_hub/en/guides/cli) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a line break here.
b83a118
to
7b786ca
Compare
Eliminate the SeeAlso section. And change to:
|
Building this locally as a man page and rendering with it with: |
My latest attempt to use reference style links seem to pass tests and also renders correctly in man page and that link is even visible there: |
How about: |
Relates-to: containers#643 Signed-off-by: Pavol Babincak <[email protected]> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: Daniel J Walsh <[email protected]>
7b786ca
to
67c7ca4
Compare
Done and IMHO it still looks fine in man page. 👍 |
Relates-to: #643
Summary by Sourcery
Documentation:
huggingface-cli
tool when logging in to Hugging Face.