-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update llama.cpp #682
Update llama.cpp #682
Conversation
To make sure we have recent deepseek changes and --jinja change. Signed-off-by: Eric Curtin <[email protected]>
Reviewer's Guide by SourceryThis pull request updates the llama.cpp commit to include recent changes, specifically to address deepseek and jinja changes. The build process was also updated to remove the llama.cpp directory after the build. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericcurtin - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide more detail in the PR description about what specific changes in this llama.cpp update are important (deepseek changes, --jinja) and why they're needed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@ericcurtin it looks like they released another new version, I filed a PR for that one 🙃 #692 |
Every commit is a new release in llama.cpp 😄 |
Merged your PR |
To make sure we have recent deepseek changes and --jinja change.
Summary by Sourcery
Build: