Revert "Added --jinja to llama-run command"

[ericcurtin]

Reverts #625

Summary by Sourcery

Enhancements:

• Restore the previous behavior of the llama-run command.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request reverts the addition of the --jinja flag to the llama-run command. The change was made in the previous pull request, but it was decided that the flag should not be included by default.

Sequence diagram for llama-run command execution without --jinja flag

sequenceDiagram
    participant User
    participant Model
    participant LlamaRun

    User->>Model: Execute llama-run
    Model->>LlamaRun: Run with context and temp
    Note over LlamaRun: No Jinja templating
    LlamaRun-->>Model: Process completion
    Model-->>User: Return results

Loading

Class diagram showing Model class changes

classDiagram
    class Model {
        +build_exec_args_run(args, model_path, prompt)
        +build_exec_args_bench(args, model_path)
    }
    note for Model "Removed --jinja flag from llama-run command arguments"

Loading

File-Level Changes

Change	Details	Files
Removed the --jinja flag from the llama-run command.	Removed the --jinja flag from the exec_args list in the build_exec_args_run function.	ramalama/model.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please provide more context in the PR description about why this feature is being reverted. This will help with future maintenance and understanding of the codebase.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ericcurtin]

@engelmi @rhatdan

I'm gonna propose we remove this just for a few weeks and re-introduce again when the newer container images have propagated to peoples machines a little more.

I'm a little worried about giving the FOSDEM talk and things not working when people try it out.

So it's just a temporary revert, for a few weeks.

[ericcurtin]

This also makes me question how well our container image versioning is actually working, I had an older container image on my machine and I was trying to run a newer version of ramalama and it didn't pull the newer image (and hence it didn't work because of lack of --jinja argument)

[engelmi]

LGTM