-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CODEOWNERS file for autoassign #706
Conversation
Let's make users and developers be aware of PRs/issues etc. Resolves: #668 Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Reviewer's Guide by SourceryThis pull request introduces a CODEOWNERS file and removes the OWNERS file. This change will enable automatic assignment of pull requests and issues to the appropriate team or individual based on the file paths modified. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dougsland - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR shows the deletion of OWNERS but doesn't include the content of the new CODEOWNERS file. Please include the ownership mappings in the new file.
- Consider documenting how the ownership information was migrated from the old OWNERS file to ensure no configurations were lost in the transition.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -1,7 +0,0 @@ | |||
approvers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we ok to remove this @rhatdan ? I don't know all the differences between these owners files.
LGTM |
Let's make users and developers be aware of PRs/issues etc.
Resolves: #668
Summary by Sourcery
Use CODEOWNERS for auto-assignment of issues and pull requests.
CI:
Chores: