Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CODEOWNERS file for autoassign #706

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Use CODEOWNERS file for autoassign #706

merged 1 commit into from
Feb 2, 2025

Conversation

dougsland
Copy link
Collaborator

@dougsland dougsland commented Feb 2, 2025

Let's make users and developers be aware of PRs/issues etc.

Resolves: #668

Summary by Sourcery

Use CODEOWNERS for auto-assignment of issues and pull requests.

CI:

  • Introduce the CODEOWNERS file.

Chores:

  • Remove the OWNERS file.

Let's make users and developers be aware of PRs/issues etc.

Resolves: #668
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Feb 2, 2025

Reviewer's Guide by Sourcery

This pull request introduces a CODEOWNERS file and removes the OWNERS file. This change will enable automatic assignment of pull requests and issues to the appropriate team or individual based on the file paths modified.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Introduce CODEOWNERS file and remove OWNERS file.
  • Added .github/CODEOWNERS file.
  • Removed OWNERS file.
.github/CODEOWNERS
OWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dougsland - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR shows the deletion of OWNERS but doesn't include the content of the new CODEOWNERS file. Please include the ownership mappings in the new file.
  • Consider documenting how the ownership information was migrated from the old OWNERS file to ensure no configurations were lost in the transition.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -1,7 +0,0 @@
approvers:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ok to remove this @rhatdan ? I don't know all the differences between these owners files.

@rhatdan
Copy link
Member

rhatdan commented Feb 2, 2025

LGTM

@rhatdan rhatdan merged commit 900eca6 into main Feb 2, 2025
10 of 11 checks passed
@ericcurtin ericcurtin deleted the codeowners branch February 2, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto-assign main developers to new issues for review?
3 participants