Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh actions: add install.sh workflow #721

Closed
wants to merge 1 commit into from

Conversation

dougsland
Copy link
Collaborator

@dougsland dougsland commented Feb 3, 2025

Summary by Sourcery

CI:

  • Add a workflow to install RamaLama using a shell script. The workflow runs on pushes and pull requests to the main branch.

Copy link
Contributor

sourcery-ai bot commented Feb 3, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new GitHub Actions workflow to install RamaLama on various operating systems. The workflow is triggered on pushes to the main branch and pull requests targeting the main branch. It sets up dependencies and executes the install_ramalama.sh script.

Flow diagram for RamaLama installation workflow

graph TD
    Start[Push/PR to main] --> Checkout[Checkout Repository]
    Checkout --> OSCheck{Check OS}
    OSCheck -->|Ubuntu| Ubuntu[Install Ubuntu Dependencies]
    OSCheck -->|macOS| MacOS[Install macOS Dependencies]
    OSCheck -->|Fedora| Fedora[Install Fedora Dependencies]
    Ubuntu --> Install[Run RamaLama Installer]
    MacOS --> Install
    Fedora --> Install
    Install --> End[Complete]
Loading

File-Level Changes

Change Details Files
Added a new GitHub Actions workflow to install RamaLama.
  • Created a workflow file named install_ramalama.yml.
  • Configured the workflow to run on push and pull requests to the main branch.
  • Defined a matrix strategy to run the workflow on Ubuntu, macOS, and Fedora.
  • Added steps to checkout the repository.
  • Added conditional steps to install dependencies (lshw and curl) based on the operating system.
  • Added a step to execute the install_ramalama.sh script with the -l flag.
.github/workflows/install_ramalama.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dougsland - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The 'fedora-latest' runner is not a valid GitHub Actions runner. GitHub Actions officially supports 'ubuntu-latest', 'windows-latest', and 'macos-latest'. Please update the matrix configuration accordingly.
  • The macOS setup uses '|| true' which silently ignores failures in the brew install command. This could mask real installation problems. Consider handling errors explicitly instead.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/workflows/install_ramalama.yml Show resolved Hide resolved
.github/workflows/install_ramalama.yml Outdated Show resolved Hide resolved
@dougsland dougsland force-pushed the workflow-ramalama branch 4 times, most recently from e6eeb0d to 6771955 Compare February 3, 2025 15:27
@dougsland
Copy link
Collaborator Author

without removing -e github actions just exit without explanion, failing with timeout in linux and error on macos.

Copy link
Collaborator

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running that script without -e doesn't make sense, the build will always pass

@ericcurtin
Copy link
Collaborator

If we add a -x in this PR and re-run a build it should show the command being troublesome

@dougsland dougsland requested a review from ericcurtin February 4, 2025 20:22
@dougsland dougsland force-pushed the workflow-ramalama branch 9 times, most recently from c4e4efe to 2c9227e Compare February 4, 2025 21:27
Resolves: containers#712
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
@dougsland dougsland closed this Feb 4, 2025
@dougsland dougsland deleted the workflow-ramalama branch February 4, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants