-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh actions: add install.sh workflow #721
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new GitHub Actions workflow to install RamaLama on various operating systems. The workflow is triggered on pushes to the main branch and pull requests targeting the main branch. It sets up dependencies and executes the install_ramalama.sh script. Flow diagram for RamaLama installation workflowgraph TD
Start[Push/PR to main] --> Checkout[Checkout Repository]
Checkout --> OSCheck{Check OS}
OSCheck -->|Ubuntu| Ubuntu[Install Ubuntu Dependencies]
OSCheck -->|macOS| MacOS[Install macOS Dependencies]
OSCheck -->|Fedora| Fedora[Install Fedora Dependencies]
Ubuntu --> Install[Run RamaLama Installer]
MacOS --> Install
Fedora --> Install
Install --> End[Complete]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dougsland - I've reviewed your changes - here's some feedback:
Overall Comments:
- The 'fedora-latest' runner is not a valid GitHub Actions runner. GitHub Actions officially supports 'ubuntu-latest', 'windows-latest', and 'macos-latest'. Please update the matrix configuration accordingly.
- The macOS setup uses '|| true' which silently ignores failures in the brew install command. This could mask real installation problems. Consider handling errors explicitly instead.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
e6eeb0d
to
6771955
Compare
without removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running that script without -e doesn't make sense, the build will always pass
If we add a -x in this PR and re-run a build it should show the command being troublesome |
6771955
to
9b4de11
Compare
c4e4efe
to
2c9227e
Compare
Resolves: containers#712 Signed-off-by: Douglas Schilling Landgraf <[email protected]>
2c9227e
to
d750ffb
Compare
Summary by Sourcery
CI: