-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github actions: ramalama install #738
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new GitHub Actions workflow to install RamaLama on push and pull request events to the main branch. The workflow runs on Ubuntu and macOS, sets up dependencies, executes the RamaLama installer, and then runs ramalama info and ramalama pull tinyllama. Flow diagram for RamaLama installation GitHub Actions workflowgraph TD
A[Push/PR to main] --> B{Matrix Strategy}
B -->|Ubuntu| C[Ubuntu Setup]
B -->|macOS| D[macOS Setup]
C --> E[Install Dependencies]
D --> F[Check Homebrew]
F -->|Not Found| G[Exit with Error]
F -->|Found| H[Install Dependencies]
E --> I[Run RamaLama Installer]
H --> I
I --> J[Run ramalama info]
J --> K[Pull tinyllama model]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dougsland - I've reviewed your changes - here's some feedback:
Overall Comments:
- The matrix comment mentions Fedora but the configuration only includes Ubuntu and macOS. Please update the comment to reflect the actual configuration.
- There are two steps with identical names 'Ramalama info'. Please use distinct names to clearly indicate their different purposes.
- Running './install.sh' with sudo without verification is a security risk. Consider documenting the source of the installer and implementing checksum verification.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
22a4136
to
63722f4
Compare
LGTM |
@rhatdan there is a comma (,) in the install that is fixed in this PR as well. |
Yes I saw that. |
@dougsland does |
yes but we had no CI and I tested with make install, that's why nobody catch that early too. |
I need to look the code to see the differences but maybe in another patch, we could do make install calling install.sh. So we have the full circle. Lets see if CI/CD will pass now (at least). |
Another example that we could handle that in our global timezone and merge it. install.sh is broken right now due comma before console.py. @rhatdan |
This PR needs to be refreshed then we can merge. |
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
63722f4
to
9f346b6
Compare
@rhatdan ready as requested. |
CI/CD failure not related to the patch. |
Summary by Sourcery
CI:
ramalama
and pull thetinyllama
model on push tomain
and pull requests targetingmain
. The workflow runs on Ubuntu and macOS and installs required dependencies likelshw
andcurl
.