Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: ramalama install #738

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

dougsland
Copy link
Collaborator

@dougsland dougsland commented Feb 4, 2025

Summary by Sourcery

CI:

  • Set up a GitHub Actions workflow to install ramalama and pull the tinyllama model on push to main and pull requests targeting main. The workflow runs on Ubuntu and macOS and installs required dependencies like lshw and curl.

Copy link
Contributor

sourcery-ai bot commented Feb 4, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new GitHub Actions workflow to install RamaLama on push and pull request events to the main branch. The workflow runs on Ubuntu and macOS, sets up dependencies, executes the RamaLama installer, and then runs ramalama info and ramalama pull tinyllama.

Flow diagram for RamaLama installation GitHub Actions workflow

graph TD
    A[Push/PR to main] --> B{Matrix Strategy}
    B -->|Ubuntu| C[Ubuntu Setup]
    B -->|macOS| D[macOS Setup]
    C --> E[Install Dependencies]
    D --> F[Check Homebrew]
    F -->|Not Found| G[Exit with Error]
    F -->|Found| H[Install Dependencies]
    E --> I[Run RamaLama Installer]
    H --> I
    I --> J[Run ramalama info]
    J --> K[Pull tinyllama model]
Loading

File-Level Changes

Change Details Files
Created a new GitHub Actions workflow to install RamaLama.
  • Added workflow trigger for push and pull request events on the main branch.
  • Configured jobs to run on Ubuntu and macOS.
  • Added steps to checkout the repository, set up dependencies (lshw, curl), run the RamaLama installer, and execute 'ramalama info' and 'ramalama pull tinyllama'.
.github/workflows/install_ramalama.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dougsland - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The matrix comment mentions Fedora but the configuration only includes Ubuntu and macOS. Please update the comment to reflect the actual configuration.
  • There are two steps with identical names 'Ramalama info'. Please use distinct names to clearly indicate their different purposes.
  • Running './install.sh' with sudo without verification is a security risk. Consider documenting the source of the installer and implementing checksum verification.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/workflows/install_ramalama.yml Outdated Show resolved Hide resolved
@dougsland dougsland force-pushed the freshinstalltest branch 4 times, most recently from 22a4136 to 63722f4 Compare February 4, 2025 21:46
@rhatdan
Copy link
Member

rhatdan commented Feb 4, 2025

LGTM
@ericcurtin PTAL

@dougsland
Copy link
Collaborator Author

@rhatdan there is a comma (,) in the install that is fixed in this PR as well.

@rhatdan
Copy link
Member

rhatdan commented Feb 4, 2025

Yes I saw that.

@rhatdan
Copy link
Member

rhatdan commented Feb 4, 2025

@dougsland does install -l blow up on errors?

@dougsland
Copy link
Collaborator Author

@dougsland does install -l blow up on errors?

yes but we had no CI and I tested with make install, that's why nobody catch that early too.

@dougsland
Copy link
Collaborator Author

dougsland commented Feb 4, 2025

@dougsland does install -l blow up on errors?

yes but we had no CI and I tested with make install, that's why nobody catch that early too.

I need to look the code to see the differences but maybe in another patch, we could do make install calling install.sh. So we have the full circle. Lets see if CI/CD will pass now (at least).

@dougsland
Copy link
Collaborator Author

@dougsland does install -l blow up on errors?

yes but we had no CI and I tested with make install, that's why nobody catch that early too.

Another example that we could handle that in our global timezone and merge it. install.sh is broken right now due comma before console.py. @rhatdan

@rhatdan
Copy link
Member

rhatdan commented Feb 5, 2025

This PR needs to be refreshed then we can merge.
LGTM

Signed-off-by: Douglas Schilling Landgraf <[email protected]>
@dougsland
Copy link
Collaborator Author

dougsland commented Feb 5, 2025

@rhatdan ready as requested.

@dougsland
Copy link
Collaborator Author

CI/CD failure not related to the patch.

@rhatdan rhatdan merged commit 5d1a71e into containers:main Feb 5, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants