-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo: Add quotes to intel-gpu argument in build llama and whisper script #766
Conversation
Reviewer's Guide by SourceryThis pull request addresses a typo by adding quotes around the 'intel-gpu' argument, ensuring it is correctly passed to the script in the Containerfile. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hanthor - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LGTM to me, you need to sign your commit with: git commit -a -s --amend and re-push |
Thanks @hanthor |
The rest of the Containerfiles have them in quotes. Don't need to be quoted at all just for consistency's sake. https://github.com/containers/ramalama/blob/main/container-images%2Fasahi%2FContainerfile#L6 |
Ok, just sign your command and we can merge. git commit -a --amend -s |
Signed-off-by: James Reilly <[email protected]>
LGTM |
Summary by Sourcery
Build:
intel-gpu
argument in thebuild_llama_and_whisper.sh
script.