Ask for confirmation before downloading the base image #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there's no easy way to get the size of the impending download. Skopeo doesn't offer the size of the OCI image [1] and it's debatable whether another 23 MB binary ought to be pulled in as a dependency just for this. Given that the default fedora-toolbox images are the only base images available via a public repository, the size of the download is hard coded to reflect the approximate size of the fedora-toolbox images. These images are between 451 MB and 483 MB, so 500 MB should be a reasonably suggestive approximate that shouldn't negatively surprise users. [1] containers/skopeo#641 https://github.com/debarshiray/toolbox/issues/134
debarshiray
force-pushed
the
wip/rishi/create-download-confirmation
branch
from
a4bea16 to
b718fbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's no easy way to get the size of the impending
download. Skopeo doesn't offer the size of the OCI image [1] and it's
debatable whether another 23 MB binary ought to be pulled in as a
dependency just for this.
Given that the default fedora-toolbox images are the only base images
available via a public repository, the size of the download is hard
coded to reflect the approximate size of the fedora-toolbox images.
These images are between 451 MB and 483 MB, so 500 MB should be a
reasonably suggestive approximate that shouldn't negatively surprise
users.
[1] containers/skopeo#641
https://github.com/debarshiray/toolbox/issues/134