create: always offer to pull

[juhp]

This PR addresses 2 common user issues with toolbox create:

• users need to manually download newer images themselves
• the hardcoded "500MB download" is misleading

I have tested this locally and it seems to work okay for me.

[softwarefactory-project-zuul]

Build succeeded.

• unit-test : SUCCESS in 2m 51s
• system-test-fedora-33 : SUCCESS in 10m 36s
• system-test-fedora-34 : SUCCESS in 10m 34s
• system-test-fedora-rawhide : SUCCESS in 19m 07s

[juhp]

Any feedback on this?
It is quite small :)

[softwarefactory-project-zuul]

Build failed.

• unit-test : SUCCESS in 5m 03s
• system-test-fedora-33 : SUCCESS in 11m 26s
• system-test-fedora-34 : SUCCESS in 10m 43s
• system-test-fedora-rawhide : TIMED_OUT in 20m 51s

[juhp]

So how about this Download <<image>> (image size ~400MB) then. Any better?

[softwarefactory-project-zuul]

Build failed.

• unit-test : SUCCESS in 4m 21s
• system-test-fedora-33 : SUCCESS in 10m 41s
• system-test-fedora-34 : SUCCESS in 11m 12s
• system-test-fedora-rawhide : TIMED_OUT in 20m 46s

[juhp]

An alternative for the pull part could be to make it an option instead:

ie toolbox create --pull ...

That would make it opt-in which should alleviate the storage space concerns with pulling newer images.
(Personally I would prefer to offer to pull by default since it is too easy to forget to pull,
but at least having the command option makes it more visible and easy to update.
It might be nice to add a purge command eventually specifically for removing obsolete toolbox images.)

Though in it's current form the user can already say "no" to downloading a newer image: they are prompted each time.

[debarshiray]

So how about this Download <<image>> (image size ~400MB) then.
Any better?

Well, the best option would be to comment on containers/skopeo#641 and push for it to get prioritized. It's not entirely trivial to get the exact size of the image.

[juhp]

Okay, sure, thank you for the detailed replies and clarity: let's drop the size part of this PR completely.

(Actually I had not realized that skopeo was only exposing local image sizes.)

[softwarefactory-project-zuul]

Build failed.

• unit-test : SUCCESS in 5m 43s
• system-test-fedora-33 : SUCCESS in 12m 15s
• system-test-fedora-34 : SUCCESS in 10m 25s
• system-test-fedora-rawhide : TIMED_OUT in 21m 05s

[sgallagher]

Any hope of reviving this PR? It would vastly simplify the documentation on how to upgrade the Developer Toolbox I maintain, for instance.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/f52aae5400a542dfb3972981e359fd43

✔️ unit-test SUCCESS in 5m 33s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 33s
✔️ unit-test-restricted SUCCESS in 5m 25s
✔️ system-test-fedora-rawhide SUCCESS in 38m 19s
✔️ system-test-fedora-40 SUCCESS in 36m 37s
✔️ system-test-fedora-39 SUCCESS in 36m 01s
✔️ system-test-fedora-38 SUCCESS in 35m 45s

[juhp]

I made my main branch current, which caused this PR to close - not that it was going anywhere...

Anyway you can still find my original proposal in 8bfbbf4 in (https://github.com/juhp/toolbox/tree/always-pull)
(I think that was it basically)