Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback for non-sse response #2097

Closed

Conversation

raja-jamwal
Copy link

@raja-jamwal raja-jamwal commented Aug 25, 2024

Description

Checklist

  • The base branch of this PR is dev, rather than main
  • The relevant docs, if any, have been updated or created

Screenshots

continue.dev loading from gpt4all

Screenshot 2024-08-25 at 12 33 55 PM

gpt4all logs

Screenshot 2024-08-25 at 12 39 57 PM

Testing

  • start gpt4all with the server mode.
  • in continue.dev use it as an OpenAI compatible provider.
  • ask something, it should respond.

@sestinj
Copy link
Contributor

sestinj commented Aug 29, 2024

@raja-jamwal thanks for taking the time to look into this!

I am slightly concerned about the complexity that this adds, just to account for a special case with GPT4All. My preference would be to make an entirely new provider for GPT4All because it isn't in the true sense "OpenAI-compatible".

This would mean adding a new file in the same folder as OpenAI.ts, which can implement similar code to OpenAI, or subclass it where appropriate. Would you be interested in trying this?

@raja-jamwal
Copy link
Author

raja-jamwal commented Sep 1, 2024

@sestinj Yes, that makes more sense. I'll make those changes.

@sestinj
Copy link
Contributor

sestinj commented Sep 10, 2024

Hi @raja-jamwal, just wanted to check in, have you had a chance to take a look at this?

@sestinj
Copy link
Contributor

sestinj commented Sep 23, 2024

I'm going to close this for now, but let me know if you have the chance to take another look and we can re-open!

@sestinj sestinj closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants