-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "My account" view #182
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I tried loading the preview URL for this PR (https://cosmos-multisig-ui-git-feat-my-account-confio.vercel.app/ ) but unfortunately get a lot of errors. Any idea why? ![]() |
This does not to work - I wanted to start the PR, and I started with the preview. All I got is:
The Multisig app only flashes for a second, and then I get an error. Something is not working. Browser is FF 118.0. Errors I get in the console are consistent with Simons:
|
Co-authored-by: Simon Warta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the explorer account link is working and visible.
I see buttons for Kplr and Ledger connections, but the first one doesn't work (and I can't check the ledger - I don't have the proper setup right now). Not sure if it is only the preview problem or if it doesn't work, and I don't know how to verify it.
Also, I see some balances previewed in the code but cannot see them on preview - I suspect it is not showing up until I connect Kepl/Ledger, which I cannot verify.
My biggest issue with this is that those should be at least three if not four, separate reviews - Ledger/Keplr connection (possibly separated), Explorer Account Link (that could be immediately merged), and balances (or most likely what you mean by "My account").
})(); | ||
}, [chain.nodeAddress, setError, walletAddress]); | ||
|
||
return balances.length ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I get this balance tab? I cannot really verify it on the preview. I assume it requires me to connect kepler, but connecting to kepler (at least on preview) seems not to work.
const { chain } = useChains(); | ||
const [loading, setLoading] = useState<LoadingStates>({}); | ||
|
||
const connectKeplr = useCallback(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see connecting keplr is just added, but it doesn't work for me really.
This new view accessible by an icon on the header allows the user to connect to Keplr or Ledger and see its address, pubkey, link to the address in an explorer, and balances on the connected chain.