Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "My account" view #182

Merged
merged 18 commits into from
Dec 18, 2023
Merged

Add "My account" view #182

merged 18 commits into from
Dec 18, 2023

Conversation

abefernan
Copy link
Contributor

This new view accessible by an icon on the header allows the user to connect to Keplr or Ledger and see its address, pubkey, link to the address in an explorer, and balances on the connected chain.

@abefernan abefernan requested a review from hashedone December 1, 2023 15:11
Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmos-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 3:28pm

@abefernan abefernan changed the base branch from master to feat/new-chainselect December 1, 2023 15:11
@webmaster128
Copy link
Member

I tried loading the preview URL for this PR (https://cosmos-multisig-ui-git-feat-my-account-confio.vercel.app/ ) but unfortunately get a lot of errors. Any idea why?

Bildschirmfoto 2023-12-12 um 09 34 57

@hashedone
Copy link

hashedone commented Dec 12, 2023

This does not to work - I wanted to start the PR, and I started with the preview. All I got is:

Application error: a client-side exception has occurred (see the browser console for more information).

The Multisig app only flashes for a second, and then I get an error. Something is not working. Browser is FF 118.0.

Errors I get in the console are consistent with Simons:

TypeError: NetworkError when attempting to fetch resource. contentScript.js:43
Uncaught (in promise) Error: Package size exceeded the configured limit of 50 MB. Try https://github.com/cosmos/chain-registry/tree/master/saga/assetlist.json instead.
    ea NextJS
2 _app-79c2fc323b4cbe33.js:3:2360088
Partitioned cookie or storage access was provided to “https://vercel.live/_next-live/feedback/feedback.html” because it is loaded in the third-party context and dynamic state partitioning is enabled.

Co-authored-by: Simon Warta <[email protected]>
Copy link

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the explorer account link is working and visible.

I see buttons for Kplr and Ledger connections, but the first one doesn't work (and I can't check the ledger - I don't have the proper setup right now). Not sure if it is only the preview problem or if it doesn't work, and I don't know how to verify it.

Also, I see some balances previewed in the code but cannot see them on preview - I suspect it is not showing up until I connect Kepl/Ledger, which I cannot verify.

My biggest issue with this is that those should be at least three if not four, separate reviews - Ledger/Keplr connection (possibly separated), Explorer Account Link (that could be immediately merged), and balances (or most likely what you mean by "My account").

})();
}, [chain.nodeAddress, setError, walletAddress]);

return balances.length ? (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I get this balance tab? I cannot really verify it on the preview. I assume it requires me to connect kepler, but connecting to kepler (at least on preview) seems not to work.

const { chain } = useChains();
const [loading, setLoading] = useState<LoadingStates>({});

const connectKeplr = useCallback(async () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see connecting keplr is just added, but it doesn't work for me really.

@webmaster128 webmaster128 merged commit dbda28d into feat/new-chainselect Dec 18, 2023
4 checks passed
@webmaster128 webmaster128 deleted the feat/my-account branch December 18, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants