Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organised_code_with_proper_indentation_&_comments #196

Closed
wants to merge 4 commits into from

Conversation

nandu-99
Copy link

@nandu-99 nandu-99 commented Mar 2, 2024

Fixes

Fixes #101 by @Xaid-vfx

Description

The code is clear and easy to follow:
- It follows common formatting and indentation styles.
- Comments are included in key areas to help other developers understand and contribute to the code.

Screenshots

#before
Screenshot 2024-03-03 at 12 38 42 AM
#after
Screenshot 2024-03-03 at 12 38 30 AM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@nandu-99 nandu-99 requested a review from a team as a code owner March 2, 2024 19:12
@nandu-99 nandu-99 requested review from TimidRobot and annatuma and removed request for a team March 2, 2024 19:12
Copy link
Contributor

@BalrajDhakad BalrajDhakad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last file wanna-work-together.html you have properly made corrections, the angle bracket of the anchor tags are hanging.

This is the screenshot highlighting the errors:-

anchor

@nandu-99
Copy link
Author

nandu-99 commented Mar 6, 2024

@BalrajDhakad Thank you, errors resolved👍

Copy link
Contributor

@BalrajDhakad BalrajDhakad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍
Keep it up

@possumbilities possumbilities requested review from possumbilities and removed request for TimidRobot and annatuma March 7, 2024 16:22
@possumbilities
Copy link
Contributor

@nandu-99 You're missing an End of File in docs/copyright-4-educators.html

@nandu-99
Copy link
Author

nandu-99 commented Mar 7, 2024

@possumbilities However, upon reviewing, I couldn't identify any obvious mistakes. Could you kindly provide more specific guidance on where the error might be? This would greatly assist me in promptly resolving the issue.

@TimidRobot
Copy link
Member

Please create a new PR based on the prettify branch (or the main branch, if it's already merged) with the comments you've added (don't forget to format using prettier before pushing your changes).

@TimidRobot TimidRobot closed this Apr 5, 2024
@TimidRobot TimidRobot self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Organise code with proper indentation and comments
4 participants