Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed link from resource images #202

Closed
wants to merge 1 commit into from
Closed

Removed link from resource images #202

wants to merge 1 commit into from

Conversation

yogeyyy
Copy link
Contributor

@yogeyyy yogeyyy commented Mar 9, 2024

Fixes

Fixes #197 by @Xaid-vfx

Description

Resource images and whitespace no longer act as links. Also, improved the formatting of the code.

Technical details

Removed the anchor tag around the resource image div to prevent unintended navigation.

Screenshots

The cursor does not change to pointer, indicating there is no link in the area
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@yogeyyy yogeyyy requested a review from a team as a code owner March 9, 2024 04:39
@yogeyyy yogeyyy requested review from TimidRobot and annatuma and removed request for a team March 9, 2024 04:39
@yogeyyy
Copy link
Contributor Author

yogeyyy commented Mar 9, 2024

@possumbilities Please review this PR. I hope it is inline with your expectations. Let me know if there is any feedback.

@yogeyyy yogeyyy changed the title Remove link from resource images Removed link from resource images Mar 9, 2024
Copy link
Contributor

@Xaid-vfx Xaid-vfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting the code is not part of #197, I would suggest fixing only the link bug mentioned in #197

Formatting and organizing the code is covered in #101, you can suggest these changes there

@yogeyyy yogeyyy closed this by deleting the head repository Mar 11, 2024
@yogeyyy
Copy link
Contributor Author

yogeyyy commented Mar 11, 2024

Ah! I get your point, closing this PR and raising a new one with the desired changes. Thanks for your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Resource Images are acting as a Link
3 participants