Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for @ page rule #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabianmieller
Copy link

@fabianmieller fabianmieller commented Aug 8, 2018

Added support for @ page rule

if rule.type === 'page' then i added the @ page rule + the selectors.

i also added a case for type 'page'.

Results:

"@page": {
        "margin": "2cm",
},
"@page :left": {
        "margin-left": "4cm",
        "margin-right": "3cm"
},
 "@page :right": {
        "margin-left": "4cm",
        "margin-right": "3cm"
}

@fabianmieller fabianmieller changed the title added support for @page added support for @ page rule Aug 8, 2018
@HenriBeck
Copy link
Member

I don't think we will accept this PR for now because @page rules aren't supported in jss yet

@kof
Copy link
Member

kof commented Aug 12, 2018

we need to add @page support, we have an issue for that in jss repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants