Skip to content

Commit

Permalink
csfilter: abstract out other precise numbers in Pylint output
Browse files Browse the repository at this point in the history
Reported-By: Pavel Raiskup
Fixes: https://github.com/kdudka/csdiff/issues/5
  • Loading branch information
kdudka committed Apr 30, 2020
1 parent 4a06205 commit 5a3e60c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion csfilter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ struct MsgFilter::Private {
addMsgFilter(checker, " \\([0-9]+/[0-9]+\\)$", "");

// "... Redefining name 'desc' from outer scope (line 10)" etc.
addMsgFilter(checker, " \\(line [0-9]+\\)$", "");
addMsgFilter(checker, " \\((?:imported )?line [0-9]+\\)$", "");
}

// "__coverity_strcmp" -> "strcmp", etc.
Expand Down
1 change: 1 addition & 0 deletions tests/diff-misc/10-pylint-copr-new.err
Original file line number Diff line number Diff line change
Expand Up @@ -503,3 +503,4 @@ from sqlalchemy.sql import false,true
/coprs_frontend/coprs/models.py:26:0: C0411[pylint]: standard import "import operator" should be placed before "from sqlalchemy import outerjoin"
/coprs_frontend/coprs/models.py:29:0: C0411[pylint]: third party import "import gi" should be placed before "from copr_common.enums import ActionTypeEnum, BackendResultEnum, FailTypeEnum, ModuleStatusEnum, StatusEnum, DefaultActionPriorityEnum"
/coprs_frontend/coprs/models.py:31:0: C0411[pylint]: third party import "from gi.repository import Modulemd" should be placed before "from copr_common.enums import ActionTypeEnum, BackendResultEnum, FailTypeEnum, ModuleStatusEnum, StatusEnum, DefaultActionPriorityEnum"
/coprs_frontend/tests/test_views/test_coprs_ns/test_coprs_general.py:706:8: W0404[pylint]: TestCoprRepoGeneration.test_works_on_older_builds: Reimport 'app' (imported line 13)
1 change: 1 addition & 0 deletions tests/diff-misc/10-pylint-copr-old.err
Original file line number Diff line number Diff line change
Expand Up @@ -504,3 +504,4 @@ from sqlalchemy.sql import false,true
/coprs_frontend/coprs/models.py:26:0: C0411[pylint]: standard import "import operator" should be placed before "from sqlalchemy import outerjoin"
/coprs_frontend/coprs/models.py:29:0: C0411[pylint]: third party import "import gi" should be placed before "from copr_common.enums import ActionTypeEnum, BackendResultEnum, FailTypeEnum, ModuleStatusEnum, StatusEnum, DefaultActionPriorityEnum"
/coprs_frontend/coprs/models.py:31:0: C0411[pylint]: third party import "from gi.repository import Modulemd" should be placed before "from copr_common.enums import ActionTypeEnum, BackendResultEnum, FailTypeEnum, ModuleStatusEnum, StatusEnum, DefaultActionPriorityEnum"
/coprs_frontend/tests/test_views/test_coprs_ns/test_coprs_general.py:607:8: W0404[pylint]: TestCoprRepoGeneration.test_works_on_older_builds: Reimport 'app' (imported line 31)

0 comments on commit 5a3e60c

Please sign in to comment.