Dense matching based line matcher #87
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging the PR in roma main, just gotta check no regressions first. |
MarkYu98
approved these changes
Oct 21, 2024
| @@ -0,0 +1,30 @@ | |||
| import os | |||
|
|
|||
| import romatch | |||
There was a problem hiding this comment.
romatch is not included in requirements.txt or dependencies
There was a problem hiding this comment.
How about we making a separate installation, as we now already make HAWP, LBD separately installed to reduce dependencies.
B1ueber2y
commented
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for RoMa inspired by its keypoint matcher here: https://github.com/Parskatt/RoMa/blob/main/romatch/models/matcher.py#L576. Currently I rely on this PR: Parskatt/RoMa#73 so one needs to RoMa from that branch. @Parskatt
For now I just support a simple one-way nearest neighbor in the end. Ideally we could do one-to-many in the end of the matching. Attached are the results after warping the lines from DeepLSD:
Added a test script here: https://github.com/cvg/limap/blob/features/dense_matching/scripts/test_matching.py
More feedbacks and tests are very welcome here.