Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potentially unbound variables #6564

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Fix potentially unbound variables #6564

merged 4 commits into from
Jan 22, 2025

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jan 17, 2025 •
edited
Loading

Split off from #6535

Suggest reviewing commit-by-commit

Context

Pylance is splashing a lot of red ink here:

image

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No stuff needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added small code refactor Large code refactors labels Jan 17, 2025
@MetRonnie MetRonnie added this to the 8.5.0 milestone Jan 17, 2025
@MetRonnie MetRonnie self-assigned this Jan 17, 2025
@MetRonnie MetRonnie mentioned this pull request Jan 17, 2025
Open
8 tasks
@MetRonnie MetRonnie requested a review from wxtim January 17, 2025 18:18
@MetRonnie MetRonnie changed the title Fix potentially undefined variables Fix potentially unbound variables Jan 17, 2025
wxtim
wxtim approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code makes sense. Code makes more sense than before.
  • Ran (locally) some functional tests which require remote platforms
    • tests/functional/remote
    • tests/functional/platforms
    • tests/functional/intelligent-host-selection

@wxtim
Copy link
Member

wxtim commented Jan 20, 2025

I've tagged @oliver-sanders for a second review.

@wxtim wxtim requested a review from oliver-sanders January 20, 2025 08:47
@oliver-sanders oliver-sanders merged commit 7cfd1ee into cylc:master Jan 22, 2025
27 checks passed
@MetRonnie MetRonnie deleted the tidy branch January 22, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@wxtim wxtim wxtim approved these changes

Assignees

@MetRonnie MetRonnie

Labels
code refactor Large code refactors small
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @wxtim @oliver-sanders