Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll comms: always process standard outputs on poll #6599

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MetRonnie
Copy link
Member

In case a task went through >1 state change since the last poll, always process the all outputs gleaned from the job poll info.

However this means that repeated polls will repeat the same outputs, so this PR also needs:

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added the could be better Not exactly a bug, but not ideal. label Feb 7, 2025
@MetRonnie MetRonnie added this to the 8.5.0 milestone Feb 7, 2025
@MetRonnie MetRonnie self-assigned this Feb 7, 2025
In case a task went through >1 state change since the last poll, always process the all outputs gleaned from the job poll info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant