Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): add scheduled send functionality #1091

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feat(backend): add scheduled send functionality #1091

wants to merge 19 commits into from

Conversation

amaninyumu1
Copy link
Member

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 7aaffb2 to 0c58a6a Compare June 16, 2024 14:58
@marclaporte
Copy link
Member

Will this work with JMAP as well?

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 0c58a6a to 0aef136 Compare June 19, 2024 08:09
@josaphatim josaphatim requested a review from kroky June 19, 2024 08:12
@amaninyumu1 amaninyumu1 marked this pull request as ready for review June 19, 2024 08:12
@kroky
Copy link
Member

kroky commented Jun 20, 2024

Yes, anything we add for IMAP, we should check JMAP support as well. Overall, it is built on top of IMAP, so it should work but please check if the new Scheduled folder is OK for JMAP.

Overall, the code is good but I have one concern - it only sends out while you are actively using Cypht and it seems to warn of unsent/scheduled messages each time you leave a page (onbeforeunload). That would be annoying for the end user. I believe this comment #576 (comment) proposes using sendAt support from jmap servers or scheduled send - if it is supported, we use it, if not, we fallback to a more annoying option. At any rate, it should be configurable.

This could be fully-supported in the Cypht-Tiki integration where there could be a Tiki command run periodically in the scheduler that checks and sends scheduled messages.

@josaphatim
Copy link
Member

@kroky I added a commit to fix issue concerning onbeforeunload event and also add the option to change schedule time or send the message immediately. Can you check please.

@josaphatim josaphatim force-pushed the Cypht-delay-send-later-scheduled-sending branch 2 times, most recently from 36599a8 to 2da4ff4 Compare June 27, 2024 13:45
@marclaporte
Copy link
Member

@amaninyumu1 If you need help with JMAP, please reach out to @Shadow243 as he set up a JMAP server for testing.

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch 2 times, most recently from 45374ae to bdf9d5d Compare July 29, 2024 20:29
@Baraka24 Baraka24 force-pushed the Cypht-delay-send-later-scheduled-sending branch 5 times, most recently from cf0574d to af1c185 Compare August 2, 2024 10:21
@marclaporte
Copy link
Member

@amaninyumu1 "This branch has conflicts that must be resolved"

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch 2 times, most recently from 141f8d9 to 16293f5 Compare September 14, 2024 06:13
@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 16293f5 to 41c9b95 Compare September 26, 2024 06:16
@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 41c9b95 to 3fb7802 Compare October 8, 2024 02:47
@marclaporte
Copy link
Member

@amaninyumu1 This branch has conflicts that must be resolved

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 3fb7802 to e725bcc Compare October 22, 2024 19:54
@amaninyumu1
Copy link
Member Author

Hello @marclaporte , @kroky I resolved the conflicts. please review

kroky
kroky reviewed Oct 23, 2024
View reviewed changes
modules/smtp/modules.php Outdated Show resolved Hide resolved
kroky
kroky reviewed Oct 23, 2024
View reviewed changes
modules/smtp/modules.php Outdated Show resolved Hide resolved
kroky
kroky reviewed Oct 23, 2024
View reviewed changes
modules/smtp/modules.php Outdated Show resolved Hide resolved
kroky
kroky reviewed Oct 23, 2024
View reviewed changes
modules/smtp/modules.php Outdated Show resolved Hide resolved
@kroky
Copy link
Member

kroky commented Oct 23, 2024

There are still conflicts and I believe big part of the reason is #1266 - @jacob-js , can you check if some handlers in this PR need to be updated according to the router changes you did in 1266?

@amaninyumu1
Copy link
Member Author

@mercihabam For your feedback #1091 (comment) Everything is good For the message sent at a certain time, the demonstration is in the videos that I had sent, but I had cut a little to show the final result seeing the state of the connection which is not stable. If there are other recommendations, I'm ready. thanks

Please do not omit any essential part in your demonstration. That part is crucial for your feature, which is why I asked for it to be included.

Yes I understand you @mercihabam the functionality in the videos. everything works

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from bd67d37 to 2df94ae Compare February 6, 2025 19:53
amaninyumu1 and others added 15 commits February 6, 2025 21:17
@amaninyumu1
feat(backend): add scheduled send functionality resolve conflicts
e77475c
@amaninyumu1
feat(backend): add scheduled send functionality
6e35072 
Removed redundant showRoutingToast() and hideRoutingToast() calls in reload_and_redirect function as navigate() handles them. Streamlined the process for scheduling and snoozing actions.
@amaninyumu1
feat(backend): clarify reload_and_redirect logic by removing unnecess…
3dcce00 
…ary isReloading
@amaninyumu1
feat(backend): refactor the code to fix the server error Uncaught Err…
1b3678d 
…or: Call to undefined method Hm_Mailbox::get_mailbox_status()
@amaninyumu1
feat(backend): add scheduled send functionality resolve conflicts in …
ba30412 
…modules/imap/functions.php
@amaninyumu1
feat(backend): change Hm_IMAP_List to Hm_Mailbox
edfbcc7
@josaphatim @amaninyumu1
Send scheduled messages via ajax
37b4dc4
@josaphatim @amaninyumu1
Make reschedule sending in a working state
115fb91
@josaphatim @amaninyumu1
Make background sending scheduled messages work
aa31793
@josaphatim @amaninyumu1
Fix showing wait message while no draft is saving
3221593
@josaphatim @amaninyumu1
Fix using Hm_IMAP_List instead of Hm_Mailbox
b10344e
@josaphatim @amaninyumu1
Fix selenium tests
34fcf4b
@amaninyumu1
feat(backend): Removing SMTP connections using the Mailbox class
f62d980
@amaninyumu1
feat(backend): update hm-ews to support these headers
4ad32cc
@amaninyumu1
feat(backend): refactor code based on review feedback
9ad1d59 
Fixed typo with double 'p'.
Used switch statement in 'get_scheduled_date'
and other
@mercihabam
Copy link
Member

No, it's not.

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch 3 times, most recently from b1f1d32 to aed9a95 Compare February 10, 2025 07:36
@amaninyumu1
feat (backend): refactor event handling and variable declarations - E…
aed9a95 
…vent handlers attached directly to target elements to avoid multiple bindings. - Rename parse_nexter_header to parse_delayed_header and Reschedule sending to Rechedule - Replacement of “var” by “let”.
@josaphatim josaphatim force-pushed the Cypht-delay-send-later-scheduled-sending branch from bd6abb8 to b35b1be Compare February 11, 2025 08:23
josaphatim
josaphatim reviewed Feb 11, 2025
View reviewed changes
modules/imap/functions.php Outdated Show resolved Hide resolved
modules/imap/functions.php Outdated Show resolved Hide resolved
modules/imap/functions.php Show resolved Hide resolved
@josaphatim josaphatim force-pushed the Cypht-delay-send-later-scheduled-sending branch from b35b1be to fcbc065 Compare February 11, 2025 08:45
@josaphatim josaphatim force-pushed the Cypht-delay-send-later-scheduled-sending branch from 92f091d to dfa6839 Compare February 11, 2025 11:06
@josaphatim
Copy link
Member

Hello @kroky. This PR is working and ready to be merged if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclaporte marclaporte marclaporte left review comments

@kroky kroky kroky left review comments

@mercihabam mercihabam mercihabam left review comments

@josaphatim josaphatim josaphatim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amaninyumu1 @marclaporte @kroky @josaphatim @mercihabam