fix(frontend): get_list_block_sieve function not callable if sievefilters module… #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christer77
changed the title
christer77
changed the title
mercihabam
reviewed
Jan 29, 2025
modules/sievefilters/site.js
Outdated
| @@ -977,6 +977,26 @@ function sieveFiltersPageHandler() { | |||
| }); | |||
| } | |||
|
|
|||
| function get_list_block_sieve() { | |||
| sessionStorage.removeItem('list_blocked'); | |||
| var detail = Hm_Utils.parse_folder_path(hm_list_path()); | |||
There was a problem hiding this comment.
- You should avoid using
varat all costs because it can lead to unintended global variable pollution. hm_list_path()andhm_page_name()are deprecated and do not always guarantee accurate results. Utility functions in modules/core/navigation/utils.js should be used instead.- What happens to the code calling
get_list_block_sieve()when the module is disabled? - Did the pull request title miss something, and why does it use the tag
other? Shouldn'tfrontendbe appropriate as the tag?
There was a problem hiding this comment.
The objective is to getthe list of blocked addresses, when the mobule is deactivated, nothing happens, i.e. the function no longer get this list
There was a problem hiding this comment.
When the module is deactivated, get_list_block_sieve will be undefined, thus, get_list_block_sieve() will throw an error in the handler function.
christer77
force-pushed
the
get_list_block_sieve_to_sieve_module
branch
from
c1d6a36 to
2551331
Compare
christer77
changed the title
|
It looks like some words are being truncated in your pull request title. Make sure to expand the title fully so that all words are visible. If necessary, you can edit the title to be more concise while still conveying the full meaning. |
|
Also, please test every change you make. Does the current code still produce the intended behavior? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue