feat(kernel): add proper console abstraction #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
d4ilyrun
commented
Jan 13, 2025
•
d4ilyrun
commented
- Dissociate the console and the underlying device
- Make it possible to switch the console's output device
- Less verbose logger prefix system
- Log level filtering
To make the distinction between the two, this commit also renames the previosuly called printf to printk. The underlying implementation stays unchanged for now.
Until now the printk implementation was forced to write to the UART output. We now write to the currently active console, thus allowing us to dynamically change the output location of our logs.
Instead of passing in the domain name for each call to the log API we now define a single LOG_DOMAIN macro at the top of a translation unit. This macro is automatically inserted into each log API calls, if present. We also took this opportunity to stop always expanding the level macros into their respective ANSI code + prefix, and instead use an enum which is in term translated into the same representation. This reduces the size of the final binary.
This attribute allows the compiler to know that these functions use the same format string as the printf function. This lets it raise warnings and errors on mis-matched argument types.
LOG_FMT_16 -> FMT16 (for uint16_t) LOG_FMT_IP -> FMT_IP (for ip addresses)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.