[2/n] Update selection syntax to use DBT style traversal syntax (javascript) #27016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
changed the title
salazarm
changed the base branch from
master
to
salazarm/update-selection-syntax
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 0e59281. |
salazarm
changed the title
hellendag
approved these changes
Jan 10, 2025
bengotow
approved these changes
Jan 13, 2025
salazarm
added a commit
that referenced
this pull request
Jan 13, 2025
…complete) (#27021) ## Summary & Motivation Update auto-complete for the selection syntax. Motivation: https://dagsterlabs.slack.com/archives/C07UYD618SF/p1735912770220549 Built on #27016 `key:my_asset+` - my_asset and all downstream assets `key:my_asset+1` - my_asset and all immediate downstream neighbors `key:my_asset+5` - my_asset and 5 layers of downstream neighbors `+key:my_asset` - my_asset and all upstream assets `1+key:my_asset` - my_asset and all immediate upstream neighbors `5+key:my_asset` - my_asset and 5 layers of upstream neighbors ## How I Tested These Changes jest test
marijncv
pushed a commit
to marijncv/dagster
that referenced
this pull request
Jan 21, 2025
…script) (dagster-io#27016) ## Summary & Motivation As titled, motivation: https://dagsterlabs.slack.com/archives/C07UYD618SF/p1735912770220549 `key:my_asset+` - my_asset and all downstream assets `key:my_asset+1` - my_asset and all immediate downstream neighbors `key:my_asset+5` - my_asset and 5 layers of downstream neighbors `+key:my_asset` - my_asset and all upstream assets `1+key:my_asset` - my_asset and all immediate upstream neighbors `5+key:my_asset` - my_asset and 5 layers of upstream neighbors ## How I Tested These Changes jest
marijncv
pushed a commit
to marijncv/dagster
that referenced
this pull request
Jan 21, 2025
…complete) (dagster-io#27021) ## Summary & Motivation Update auto-complete for the selection syntax. Motivation: https://dagsterlabs.slack.com/archives/C07UYD618SF/p1735912770220549 Built on dagster-io#27016 `key:my_asset+` - my_asset and all downstream assets `key:my_asset+1` - my_asset and all immediate downstream neighbors `key:my_asset+5` - my_asset and 5 layers of downstream neighbors `+key:my_asset` - my_asset and all upstream assets `1+key:my_asset` - my_asset and all immediate upstream neighbors `5+key:my_asset` - my_asset and 5 layers of upstream neighbors ## How I Tested These Changes jest test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As titled, motivation: https://dagsterlabs.slack.com/archives/C07UYD618SF/p1735912770220549
key:my_asset+- my_asset and all downstream assetskey:my_asset+1- my_asset and all immediate downstream neighborskey:my_asset+5- my_asset and 5 layers of downstream neighbors+key:my_asset- my_asset and all upstream assets1+key:my_asset- my_asset and all immediate upstream neighbors5+key:my_asset- my_asset and 5 layers of upstream neighborsHow I Tested These Changes
jest