Skip to content

Commit

Permalink
fix ns
Browse files Browse the repository at this point in the history
  • Loading branch information
danielgafni committed Sep 16, 2024
1 parent e8eb4d2 commit 81bd199
Show file tree
Hide file tree
Showing 3 changed files with 69 additions and 3 deletions.
60 changes: 59 additions & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ license = "Apache-2.0"
python = ">=3.8.1,<3.13"
dagster = ">=1.8.0"
tenacity = ">=8.0.0"
grpcio = [
{version = "*", python = "<3.12"},
{version = ">=1.60.0", python = ">=3.12"}
]
greenlet = [
{version = "*", python = "<3.12"},
{version = ">=3.0", python = ">=3.12"}
Expand Down
8 changes: 6 additions & 2 deletions tests/test_kuberay/test_raycluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ def dagster_ray_image():

KUBERAY_VERSIONS = os.getenv("PYTEST_KUBERAY_VERSIONS", "1.2.0").split(",")

NAMESPACE = "ray"


@pytest_cases.fixture(scope="session")
@pytest.mark.parametrize("kuberay_version", KUBERAY_VERSIONS)
Expand Down Expand Up @@ -117,7 +119,7 @@ def k8s_with_kuberay(

k8s.wait("deployment/kuberay-operator", "condition=Available=True", namespace="kuberay-operator")
# namespace to create RayClusters in
k8s.kubectl(["create", "namespace", "kuberay"])
k8s.kubectl(["create", "namespace", NAMESPACE])
yield k8s
k8s.delete()

Expand Down Expand Up @@ -155,6 +157,7 @@ def ray_cluster_resource(
client=RayClusterClientResource(kubeconfig_file=str(k8s_with_kuberay.kubeconfig)),
ray_cluster=RayClusterConfig(
image=dagster_ray_image,
namespace=NAMESPACE,
head_group_spec=head_group_spec,
worker_group_specs=worker_group_specs,
),
Expand All @@ -179,6 +182,7 @@ def ray_cluster_resource_skip_cleanup(
client=RayClusterClientResource(kubeconfig_file=str(k8s_with_kuberay.kubeconfig)),
ray_cluster=RayClusterConfig(
image=dagster_ray_image,
namespace=NAMESPACE,
head_group_spec=head_group_spec,
worker_group_specs=worker_group_specs,
),
Expand Down Expand Up @@ -275,7 +279,7 @@ def my_asset(ray_cluster: RayResource) -> None:
},
run_config=RunConfig(
ops={
"cleanup_kuberay_rayclusters": CleanupKuberayClustersConfig(
"cleanup_kuberay_clusters": CleanupKuberayClustersConfig(
namespace=ray_cluster_resource_skip_cleanup.namespace,
)
}
Expand Down

0 comments on commit 81bd199

Please sign in to comment.