DAOS-17146 engine: call only pmemobj_close() on stop #16051
+236
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `dmg system stop` -> SIGINT will trigger a new server stop path which:
- stops all the execution streams to stop them from using the PMEM
pools
- close all the PMEM pools (`pmemobj_close()`)
- terminate the `daos_engine` process
- `dmg system stop --force` -> SIGKILL remains as the last resort in
case the previous one stucks
- the graceful teardown process will be unavailable till we fix it
(DAOS-XXXX)
Priority: 2
Signed-off-by: Jan Michalski <[email protected]>
|
Ticket title is 'Make sure |
osalyk
reviewed
Mar 7, 2025
| @@ -195,6 +195,8 @@ struct dss_xstream *dss_get_xstream(int stream_id); | |||
| int dss_xstream_cnt(void); | |||
| void dss_mem_total_alloc_track(void *arg, daos_size_t bytes); | |||
| void dss_mem_total_free_track(void *arg, daos_size_t bytes); | |||
| void | |||
There was a problem hiding this comment.
Please maintain consistency in formatting.
There was a problem hiding this comment.
I can't. It is what clang-format does. I don't like it either.
| * | ||
| * \param[in] is_sysdb close sysdb. | ||
| */ | ||
| void |
| @@ -622,6 +623,9 @@ int d_uhash_link_insert(struct d_hash_table *htable, struct d_uuid *key, | |||
| void *cmp_args, struct d_ulink *ulink); | |||
| struct d_ulink *d_uhash_link_lookup(struct d_hash_table *htable, | |||
| struct d_uuid *key, void *cmp_args); | |||
| typedef int (*d_uhash_traverse_cb_t)(struct d_ulink *link, void *arg); | |||
| int | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dmg system stop-> SIGINT will trigger a new server stop path which:pmemobj_close())daos_engineprocessdmg system stop --force-> SIGKILL remains as the last resort in case the previous one stucksPriority: 2
Steps for the author:
After all prior steps are complete: