-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding spec.metadata.pemContents to MySQL Binding #3620
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ed <[email protected]>
8fec658
to
5991b8f
Compare
Signed-off-by: Ed <[email protected]>
* moved mysql.RegisterTLSConfig ahead of mysql.ParseDSN * added unit tests for InitDB to check for PEM and ParseDSN errors Signed-off-by: Ed <[email protected]>
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
@edwardfward Can you please comment on the state of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this test case to the certification test.
https://github.com/dapr/components-contrib/blob/main/tests/certification/state/mysql/mysql_test.go
You can see some other components which use a dedicated component yaml for a test case - please don't edit the existing component yaml used in tests.
We will want to dynamically generate a certificate - then start a MySQL server via Docker configured to use this certificate, then have the component yaml specify the required certificate.
You may need to do so by using the secret store reference to load the contents from file or an environment variable.
Please do not hardcode a certificate in the component yaml and do not check in a certificate file.
Description
Incorporated
spec.metadata.pemContents
to MySQL binding to provide a means to build SSL-secured bindings for apps deployed in Azure Container Apps.Issue reference
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: