Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spec.metadata.pemContents to MySQL Binding #3620

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

edwardfward
Copy link

@edwardfward edwardfward commented Nov 30, 2024

Description

Incorporated spec.metadata.pemContents to MySQL binding to provide a means to build SSL-secured bindings for apps deployed in Azure Container Apps.

Issue reference

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@edwardfward edwardfward changed the title Adding spec.metadata.pemContents to MySQL Binding [WIP] Adding spec.metadata.pemContents to MySQL Binding Dec 1, 2024
* moved mysql.RegisterTLSConfig ahead of mysql.ParseDSN
* added unit tests for InitDB to check for PEM and ParseDSN errors

Signed-off-by: Ed <[email protected]>
@edwardfward edwardfward changed the title [WIP] Adding spec.metadata.pemContents to MySQL Binding Adding spec.metadata.pemContents to MySQL Binding Dec 1, 2024
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jan 19, 2025
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 26, 2025
@msfussell msfussell reopened this Feb 7, 2025
@msfussell
Copy link
Member

@edwardfward Can you please comment on the state of this PR?

@github-actions github-actions bot removed the stale label Feb 7, 2025
Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this test case to the certification test.

https://github.com/dapr/components-contrib/blob/main/tests/certification/state/mysql/mysql_test.go

You can see some other components which use a dedicated component yaml for a test case - please don't edit the existing component yaml used in tests.

We will want to dynamically generate a certificate - then start a MySQL server via Docker configured to use this certificate, then have the component yaml specify the required certificate.

You may need to do so by using the secret store reference to load the contents from file or an environment variable.

Please do not hardcode a certificate in the component yaml and do not check in a certificate file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add spec.metadata.pemContents to MySQL & MariaDB binding spec
4 participants