Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

components-path --> resources-path in how-tos and quickstarts #3016

Merged
merged 6 commits into from
Jan 18, 2023
Merged

components-path --> resources-path in how-tos and quickstarts #3016

merged 6 commits into from
Jan 18, 2023

Conversation

hhunter-ms
Copy link
Collaborator

Description

PR alongside #2999 for how-tos and quickstarts

Issue reference

PR will close: #2998

@hhunter-ms hhunter-ms requested review from a team as code owners December 16, 2022 19:25
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 26, 2022
@pravinpushkar
Copy link
Contributor

not stale

@github-actions github-actions bot removed the stale label Dec 27, 2022
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 1, 2023
@hhunter-ms hhunter-ms removed the stale label Jan 3, 2023
@hhunter-ms
updates per pravin
225c6ec 
Signed-off-by: Hannah Hunter <[email protected]>
@msfussell msfussell added this to the 1.10 milestone Jan 4, 2023
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 10, 2023
@msfussell msfussell removed the stale label Jan 10, 2023
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 16, 2023
@hhunter-ms hhunter-ms removed the stale label Jan 17, 2023
@hhunter-ms
mark components-path as deprecated
1c2510d 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
reword
367ab9a 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Copy link
Collaborator Author

@pravinpushkar @msfussell updated per comments

msfussell
msfussell approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 235626f into dapr:v1.10 Jan 18, 2023
@pravinpushkar pravinpushkar mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukundansundar mukundansundar mukundansundar left review comments

@pravinpushkar pravinpushkar pravinpushkar left review comments

@msfussell msfussell msfussell approved these changes

Assignees

@hhunter-ms hhunter-ms

Labels
None yet
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@hhunter-ms @pravinpushkar @msfussell @mukundansundar