Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resiliency example typo #4464

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

antontroshin
Copy link
Contributor

The schema field is called matching
https://github.com/dapr/dapr/blob/6c488fdf7d2995d074413c875fc2e3fb4134a33b/pkg/apis/resiliency/v1alpha1/types.go#L58

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

#4463

Signed-off-by: Anton Troshin <[email protected]>
@hhunter-ms
Copy link
Collaborator

@antontroshin do you think this field should be added to the resiliency schema, as well?

@hhunter-ms hhunter-ms merged commit b3f8cd7 into dapr:v1.15 Dec 16, 2024
4 checks passed
@antontroshin antontroshin deleted the fix-resiliency-typo branch December 18, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants