Added Dapr Jobs .NET Quickstart #1131
Conversation
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
| throw new Exception("Unable to deserialize the payload from the scheduled job invocation"); | ||
| } | ||
|
|
||
| await daprClient.InvokeMethodAsync(HttpMethod.Get, "etl-svc", $"/etl/{payload.TaskId}", cancellationToken); |
There was a problem hiding this comment.
what do you think about using the "http proxy" approach to invoking the http call instead like we do in the basic service invoke quickstart? https://docs.dapr.io/getting-started/quickstarts/serviceinvocation-quickstart/
that shows you can keep using your favorite HTTP client and just pass a header, making dapr look a bit more familiar.
There was a problem hiding this comment.
Also can we sync to release-1.15 and try to get these C# checks to pass?
There was a problem hiding this comment.
As this was the SDK quickstart, I opted to use the SDK-style service invocation instead of HttpClient as I figured that was better featured in the HTTP quickstart.
A sync to release-1.15 does not appear to be in the cards for me until all my PRs are closed. As best I can tell I'm going to have to delete my GitHub fork and re-create it to get it to sync anything but master (as it's the only branch I originally forked).
There was a problem hiding this comment.
We are deprecating the InvokeMethodAsync calls fyi!
Signed-off-by: Whit Waldo <[email protected]>
|
@WhitWaldo Im going to propose we move this one to the dotnet samples repo as well to maintain consistency with the other Jobs samples! This is great but I think the sample needs to be consistent here. |
|
We can just close this then. The .NET repo already has an equivalent example, so no need to merge over a duplicate. |
Description
Do not merge yet:
README is incomplete until this bug can be resolved.
Issue reference
N/A - part of 1.15 endgame
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: