Python Conversation http Quickstart #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fernando Rocha <[email protected]>
alicejgibbons
requested changes
Jan 28, 2025
|
|
||
| This quickstart includes one app: | ||
|
|
||
| - `conversation.py`, responsible for sending an input to the underlying LLM and retrieving an output. |
There was a problem hiding this comment.
Suggested change
| - `conversation.py`, responsible for sending an input to the underlying LLM and retrieving an output. | |
| - `app.py`, responsible for sending an input to the underlying LLM and retrieving an output. |
| dapr stop -f . | ||
| ``` | ||
|
|
||
| <!-- END_STEP --> |
There was a problem hiding this comment.
@rochabr can you add a section to run the app without the mutli app run files? You can copy most of the text from the other Python one, but we should always have an option for Dapr CLI only.
| base_url = os.getenv('BASE_URL', 'http://localhost') + ':' + os.getenv( | ||
| 'DAPR_HTTP_PORT', '3500') | ||
|
|
||
| CONVERSATION_NAME = 'echo' |
There was a problem hiding this comment.
Can we name this something better than Conversation? Maybe CONVERSATION_COMPONENT_NAME? or something
| data = result.json() | ||
| output = data["outputs"][0]["result"] | ||
|
|
||
| logging.info('Input sent: What is dapr?') |
There was a problem hiding this comment.
Would also suggest to move this printline up to just after line 26
Signed-off-by: Fernando Rocha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating Conversation Quickstart for Python - HTTP
Issue reference
Please reference the issue this PR will close: #1108
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: