Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: new rc #1161

Draft
wants to merge 1 commit into
base: release-1.15
Choose a base branch
from
Draft

Chore: new rc #1161

wants to merge 1 commit into from
+1 −1

Conversation

alicejgibbons
Copy link

@alicejgibbons alicejgibbons commented Feb 7, 2025 •
edited
Loading

Description

Fix python failing tests

Issue reference

#1143

Please reference the issue this PR will close: #1143

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@alicejgibbons
chore:RC 11
2c02414 
Signed-off-by: Alice Gibbons <[email protected]>
@alicejgibbons alicejgibbons requested review from a team as code owners February 7, 2025 19:43
rochabr

This comment was marked as outdated.

Sign in to view

@rochabr rochabr self-requested a review February 8, 2025 07:24
rochabr
rochabr reviewed Feb 8, 2025
View reviewed changes
Copy link
Contributor

@rochabr rochabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but the tests are still failing. it doesn't look related to the previous bug, though. can we check?

@alicejgibbons alicejgibbons marked this pull request as draft February 10, 2025 13:37
msfussell
msfussell approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochabr rochabr rochabr approved these changes

@msfussell msfussell msfussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alicejgibbons @rochabr @msfussell