-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept a list of pids from deferred allowance function #7
Merged
whatyouhide
merged 6 commits into
dashbitco:main
from
am-kantox:accept-list-of-pids-for-lazy-resolve
Jul 29, 2024
Merged
Accept a list of pids from deferred allowance function #7
whatyouhide
merged 6 commits into
dashbitco:main
from
am-kantox:accept-list-of-pids-for-lazy-resolve
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For coverage, if desired, I might add another test with fn ->
[Process.whereis(:lazy_pid_1), :not_a_pid, Process.whereis(:lazy_pid_2)]
end, |
Yeah I can't think of a better way to do this off the top of my head. 👍 |
whatyouhide
reviewed
Jul 29, 2024
Co-authored-by: Andrea Leopardi <[email protected]>
am-kantox
commented
Jul 29, 2024
am-kantox
commented
Jul 29, 2024
am-kantox
commented
Jul 29, 2024
@whatyouhide everything’s applied, coverage fixed; sorry for the mess with multiple commits, squash them or something. |
Thanks @am-kantox 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with pools of anonymous workers, one might want to allow all the workers from the whole pool. Again, it mostly makes sense in test environment.
Unfortunately, there is no way to call
allow/5
subsequently (as we do with a straightforward, non-deferred calls) because the workers can be resolved as a whole list within the context of the deferred call only.To satisfy the aforementioned requirement (the contrived use-case might be found here although I understand it’s not the normal way of doing it, but still, pools are widely used and the ability to allow all workers looks natural to me,) this PR proposes the function to lazy resolve the allowances to be permitted to return lists of pids.