-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search functionality to prevent full page reload #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akita
|
Project |
akita
|
Branch Review |
bugfix/prevent-search-reload
|
Run status |
|
Run duration | 01m 45s |
Commit |
|
Committer | Joseph Rhoads |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
3
|
|
0
|
|
50
|
View all changes introduced in this branch ↗︎ |
I love this and have been meaning to ask if this is something we could smooth out. Great job, @jrhoads ! Looks really good in my testing. |
wendelfabianchinsamy
approved these changes
Feb 6, 2025
akita
|
Project |
akita
|
Branch Review |
1.20.0
|
Run status |
|
Run duration | 01m 42s |
Commit |
|
Committer | Joseph Rhoads |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
3
|
|
0
|
|
50
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses issue #454: Search Functionality Causing Full Page Reload and React Query Cache Invalidation
The PR aims to improve the search experience across different search types (works, people, organizations, and repositories) by optimizing the search functionality and preventing unnecessary page reloads.
Approach
The changes focus on enhancing the search component's behavior and ensuring a smoother user experience:
Key Modifications
useEffect
to update search input when URL changesSearchDoiPage
toSearchOrganizationPage
Important Technical Details
Types of changes
Reviewer, please remember our guidelines: