Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Set a default value to options parameter #16

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

Sarrabah
Copy link
Collaborator

@Sarrabah Sarrabah commented Jul 24, 2024

  • The aim of this PR is to avoid using the options parameter when instantiating the class. For example, change from "_code_postal = CodePostal(Options())" to "_code_postal = CodePostal()".
    In this case, options has a default value (all options are false) .

refactor: Initialize options

refactor: Ignore constructor call

fix: Add Optional

refactor: Reuse th constructor

refactor: Use public parameter
@Sarrabah Sarrabah force-pushed the refactor/options_default_values branch from 1784446 to 3116b30 Compare July 25, 2024 13:30
@Sarrabah Sarrabah requested a review from pierrecamilleri July 25, 2024 14:23
@Sarrabah Sarrabah changed the title Refactor: Add a new constructor Refactor: Delete the options parameter Jul 25, 2024
src/frformat/custom_format.py Outdated Show resolved Hide resolved
src/frformat/enum_format.py Outdated Show resolved Hide resolved
@Sarrabah Sarrabah changed the title Refactor: Delete the options parameter Refactor: Set a default value to options parameter Jul 30, 2024
@Sarrabah Sarrabah marked this pull request as ready for review July 30, 2024 15:58
@Sarrabah Sarrabah merged commit 5733c74 into main Jul 31, 2024
2 checks passed
@Sarrabah Sarrabah deleted the refactor/options_default_values branch July 31, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants