Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve data storage for code commune versions #36

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

perf: improve data storage for code commune versions #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b3aaa12
refactor:Refactor code region test with new class
Sarrabah Nov 25, 2024
cee6a91
refactor: Implement the table driven tests
Sarrabah Nov 25, 2024
83c706c
refactor: Use the TDT with Region
Sarrabah Nov 25, 2024
dcbefcf
refactor: Implement TDT with Commune
Sarrabah Nov 25, 2024
0a9abc5
refactor: Implement TDT with Canton code
Sarrabah Nov 25, 2024
5951e44
refactor: Implement TDT with Pays code IS02 and IS03
Sarrabah Nov 25, 2024
548a04a
refactor: Implement TDT with Departement code
Sarrabah Nov 25, 2024
bc6c315
refactor: Implement TDT with Pays
Sarrabah Nov 25, 2024
4df095d
refactor: Implement TDT with Numero Departement
Sarrabah Nov 25, 2024
a01c251
refactor: Renaming
Sarrabah Nov 26, 2024
e6edfcf
refactor: Remove the nested dictionnary
Sarrabah Nov 26, 2024
59c6f0a
Give a unique name for each test case
Sarrabah Nov 26, 2024
1b385fc
refactor: Implement TDT with Code Commune Insee
Sarrabah Nov 26, 2024
c68c7b1
test: Add a message when the test fails
Sarrabah Nov 26, 2024
19d2b15
perf: Use a new const to have all the repeated values
Sarrabah Nov 27, 2024
390d0ac
refactor: Remove comments
Sarrabah Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/frformat/geo/code_commune_insee.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,19 @@

from frformat import geo_enum_format
from frformat.geo.code_commune_insee_frozenset import (
CODES_COMMUNES_INSEE_COG_2023,
CODES_COMMUNES_INSEE_COG_2024,
INTERSECTION_CODE_COMMUNE_INSEE,
SPECIFIC_VALUES_CODE_COMMUNES_INSEE_COG_2023,
SPECIFIC_VALUES_CODE_COMMUNES_INSEE_COG_2024,
)
from frformat.geo_enum_format import Millesime

name = "Code commune INSEE"
description = "Vérifie que le code commune correspond bien à un code commune INSEE pour un Code Officiel Géographique donné"

all_cog_versions: Dict[Millesime, FrozenSet[str]] = {
Millesime.M2023: CODES_COMMUNES_INSEE_COG_2023,
Millesime.M2024: CODES_COMMUNES_INSEE_COG_2024,
Millesime.M2023: SPECIFIC_VALUES_CODE_COMMUNES_INSEE_COG_2023,
Millesime.M2024: SPECIFIC_VALUES_CODE_COMMUNES_INSEE_COG_2024,
Millesime.INTERSECTION: INTERSECTION_CODE_COMMUNE_INSEE,
}
CodeCommuneInsee = geo_enum_format.new(
"CodeCommuneInsee", name, description, all_cog_versions
Expand Down
Loading
Loading