feat: validation codes geo et autres #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrecamilleri
force-pushed
the
feat/Validation_codes_geo_et_autres
branch
from
595ca69 to
8bafd35
Compare
There was a problem hiding this comment.
Merci !
En plus des points que j'ai soulevés, pour finaliser cette PR, il reste à :
- factoriser
CustomStrFormatetCustomFloatFormat - Rajouter la longitude (les deux vont souvent ensemble !)
EDIT : ah et un détail supplémentaire : j'ai fait un rebase + force push, donc n'oublies pas de récupérer la branche distante. La manière la plus simple à mon sens :
# Récupérer les changements distants
git fetch
# Supprimer la branche localement - attention de ne pas avoir de changements absents de la branche distante !
git branch -D feat/Validation_codes_geo_et_autres
# Recréer à partir de la branch distante
git switch feat/Validation_codes_geo_et_autres
Sarrabah
changed the title
Sarrabah
force-pushed
the
feat/Validation_codes_geo_et_autres
branch
from
cff11e8 to
8b4b803
Compare
Sarrabah
force-pushed
the
feat/Validation_codes_geo_et_autres
branch
from
8b4b803 to
9fb1b51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR a pour but d'initialiser la validation de codes suivants:
*latitude_l93
*longitude_l93
*code_rna