Upgrade to Bootstrap v5 #1028
Draft
Upgrade to Bootstrap v5 #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminCharmes
force-pushed
the
bc/update-bootstrap5
branch
from
0b62df8 to
5b3c114
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
=======================================
Coverage 70.04% 70.04%
=======================================
Files 62 62
Lines 3996 3996
=======================================
Hits 2799 2799
Misses 1197 1197
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/update-bootstrap5
|
| Run status |
|
| Run duration | 06m 51s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
471
|
| View all changes introduced in this branch ↗︎ | |
BenjaminCharmes
force-pushed
the
bc/update-bootstrap5
branch
from
dfc981f to
a09a084
Compare
BenjaminCharmes
force-pushed
the
bc/update-bootstrap5
branch
from
48d928f to
70ae51b
Compare
BenjaminCharmes
added
webapp
BenjaminCharmes
force-pushed
the
bc/update-bootstrap5
branch
from
f4630f0 to
05f278f
Compare
BenjaminCharmes
force-pushed
the
bc/update-bootstrap5
branch
from
d4dba9e to
7a936d1
Compare
Update Bootstrap to v5 and update components Update components with new Bootstrap 5 class New badge class Update CreateItemModal with new classes Update CreateCollectionModal with new classes Update CreateEquipmentModal with new classes Update QRScannerModal with new classes Update CreateEquipmentModal with new classes Update BatchCreateItemModal with new classes Update EditAccountSettingsModal and Modal close btn More updates More updates More components updates More components updates Update cypress test Fix cypress e2e editPage Fix cypress e2e batchSample Fix modelValue warnings in console Update for better mobile support Update CompactConstituentTable for better mobile support Edit EditPage Navbar to better mobile support Edit DynamicDataTableButtons to better mobile support Fix FileList with Bootstrap5 Update CollectionInformation and CollectionPage for better mobile support Update bokeh_plots to fit on mobile Fix cypress tests
ml-evs
force-pushed
the
bc/update-bootstrap5
branch
from
7a936d1 to
3c10d26
Compare
ml-evs
requested changes
Jan 28, 2025
| @@ -23,7 +23,8 @@ | |||
| "@uppy/webcam": "^1.8.4", | |||
| "@uppy/xhr-upload": "^1.6.10", | |||
| "@vueuse/components": "^10.7.2", | |||
| "bootstrap": "^4.5.3", | |||
| "boostrap": "^2.0.0", | |||
There was a problem hiding this comment.
Suggested change
| "boostrap": "^2.0.0", |
👁️ think this one needs to be removed! Thankfully this is one where npm have sat on the name to prevent malicious use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
For now:
<button />class used to closeModalml-2(doesn't exist in Bootstrap v5) bygap-2(d-flex) forDynamicDataTableButtons(could also useme-2from bootstrap instead) (Bootstrap left and right replaced by start and end)color: blackto FormattedItemName becausebadge lightdisplay text in white nowTo discuss:
To do:
Also start working on #620: