Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ally): increased weak badge border color contrast #3890

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Mar 3, 2025

Proposed changes

Resolves #3887

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🐛bug Something isn't working 👂accessibility Accessibility issues/improvements labels Mar 3, 2025
@mfranzke mfranzke self-assigned this Mar 3, 2025
@mfranzke mfranzke requested a review from nmerget as a code owner March 3, 2025 17:55
@mfranzke mfranzke linked an issue Mar 3, 2025 that may be closed by this pull request
7 tasks
Copy link
Contributor

github-actions bot commented Mar 3, 2025

@github-actions github-actions bot added the 🏘components Changes inside components folder label Mar 3, 2025
@mfranzke
Copy link
Collaborator Author

mfranzke commented Mar 3, 2025

@leape QS URLs:

I assume that a change to the badge should also change the weak tag (mainly as those were interconnected for some declarations in the past). If this is a misunderstanding, please let me know.

@leape
Copy link
Contributor

leape commented Mar 4, 2025

The border color of the tag remains unchanged at emphasis-60.

One thing about the badge: Emphasis weak has bg-basic-level-3 as background, the rest is fine! Thanks.

@mfranzke mfranzke enabled auto-merge (squash) March 4, 2025 18:41
@mfranzke mfranzke assigned nmerget and unassigned mfranzke Mar 4, 2025
@mfranzke mfranzke changed the title refactor: changed this one to a heavier color fix(ally): increased weak badge border color contrast Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👂accessibility Accessibility issues/improvements 🐛bug Something isn't working 🏘components Changes inside components folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(ally): change border color for weak badge/tag
3 participants