-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for running sample mode
with build
command
#11307
Allow for running sample mode
with build
command
#11307
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11307 +/- ##
==========================================
- Coverage 88.95% 88.89% -0.07%
==========================================
Files 189 189
Lines 24169 24170 +1
==========================================
- Hits 21500 21486 -14
- Misses 2669 2684 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for a node that cannot be sampled? E.g. exposures
@aranke Hmmm I'm not sure I agree. In the specific context of exposures, there isn't a way I'm aware of to test this. Exposures are leaf nodes and thus can't be ref'd, which doesn't seem in the purview of this work. There is an argument of, we should test whether the There is an argument for the general "test for a node that cannot be sampled". However, I don't think it is actually time for that yet. Sample mode is still in alpha/beta, and using it is gated behind an environment variable. Our general goal for GA is that for anything that render's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified with @QMalcolm offline, this only affects nodes that can be called via ref
or source
.
Resolves #11298
Problem
Sample mode could only be run with
run
command, we want to also use it withbuild
commandSolution
Allow for specification of
--sample=SAMPLE_SPEC
onbuild
commandChecklist