Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add database to ModelNodeArgs in partial parsing test to better reflect prod use cases #11330

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

MichelleArk
Copy link
Contributor

database on ModelNodeArgs is optional to mirror the manifest schema, but in practice this is rarely the case.

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Feb 21, 2025
@cla-bot cla-bot bot added the cla:yes label Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (71a93b0) to head (be8d78b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11330      +/-   ##
==========================================
- Coverage   88.97%   88.90%   -0.08%     
==========================================
  Files         189      189              
  Lines       24182    24182              
==========================================
- Hits        21515    21498      -17     
- Misses       2667     2684      +17     
Flag Coverage Δ
integration 86.13% <ø> (-0.15%) ⬇️
unit 62.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.55% <ø> (ø)
Integration Tests 86.13% <ø> (-0.15%) ⬇️

@MichelleArk MichelleArk marked this pull request as ready for review February 21, 2025 20:39
@MichelleArk MichelleArk requested a review from a team as a code owner February 21, 2025 20:39
@MichelleArk MichelleArk merged commit f7c4c3c into main Feb 21, 2025
63 of 64 checks passed
@MichelleArk MichelleArk deleted the improve-ext-table-partial-test branch February 21, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants