-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle ubuntu 20.04 deprecation #11354
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11354 +/- ##
==========================================
- Coverage 88.91% 88.89% -0.02%
==========================================
Files 190 190
Lines 24197 24197
==========================================
- Hits 21514 21510 -4
- Misses 2683 2687 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d8b9e10
to
63faea8
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-11354-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77d8e3262a1b8b54eed6386c9b9841b73b080366
# Push it to GitHub
git push --set-upstream origin backport-11354-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-11354-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77d8e3262a1b8b54eed6386c9b9841b73b080366
# Push it to GitHub
git push --set-upstream origin backport-11354-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3.latest 1.3.latest
# Navigate to the new working tree
cd .worktrees/backport-1.3.latest
# Create a new branch
git switch --create backport-11354-to-1.3.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77d8e3262a1b8b54eed6386c9b9841b73b080366
# Push it to GitHub
git push --set-upstream origin backport-11354-to-1.3.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-11354-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77d8e3262a1b8b54eed6386c9b9841b73b080366
# Push it to GitHub
git push --set-upstream origin backport-11354-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-11354-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77d8e3262a1b8b54eed6386c9b9841b73b080366
# Push it to GitHub
git push --set-upstream origin backport-11354-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.4.latest 1.4.latest
# Navigate to the new working tree
cd .worktrees/backport-1.4.latest
# Create a new branch
git switch --create backport-11354-to-1.4.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77d8e3262a1b8b54eed6386c9b9841b73b080366
# Push it to GitHub
git push --set-upstream origin backport-11354-to-1.4.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.4.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.9.latest 1.9.latest
# Navigate to the new working tree
cd .worktrees/backport-1.9.latest
# Create a new branch
git switch --create backport-11354-to-1.9.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77d8e3262a1b8b54eed6386c9b9841b73b080366
# Push it to GitHub
git push --set-upstream origin backport-11354-to-1.9.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.9.latest Then, create a pull request where the |
* update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]>
* update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml
* update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml
* update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml # .github/workflows/main.yml
* update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml # .github/workflows/main.yml
* update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml # .github/workflows/main.yml # .github/workflows/structured-logging-schema-check.yml
* update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]>
* handle ubuntu 20.04 deprecation (#11354) * update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml * remove entire action
* update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml
* handle ubuntu 20.04 deprecation (#11354) * update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml # .github/workflows/main.yml * upgrade ubuntu
* handle ubuntu 20.04 deprecation (#11354) * update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml # .github/workflows/main.yml * upgrade ubuntu
* handle ubuntu 20.04 deprecation (#11354) * update ubuntu 20.04 to 24.04 * updates to ubuntu-latest instead * try postgres update * Change owner of db creation script so postgres can run it. * Add sudos. * Add debug logging. * Set execute bit on scripts. * More debug logging. * try a service * clean up and split the integrations tests by os --------- Co-authored-by: Peter Allen Webb <[email protected]> # Conflicts: # .github/actions/setup-postgres-linux/action.yml # .github/workflows/main.yml # .github/workflows/structured-logging-schema-check.yml * conflict fixes
Problem
ubuntu 20.04 is EOL and GHA support is ending
Solution
Switch to use the GH runner postgres container for linux but continue the more manual docker setup for windows + macos. Windows/macos can't use the GHA service containers. However ubuntu-24.04 is causing some permission issues we're having trouble figuring out.
Note: this solution requires updates to dbt-releases since it deletes the action. We need to update that repo anyways though since it uses 20.04.
Checklist