Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RST Rendering for Blog Articles #11

Merged
merged 2 commits into from
Aug 7, 2024
Merged

RST Rendering for Blog Articles #11

merged 2 commits into from
Aug 7, 2024

Conversation

tanneberger
Copy link
Member

No description provided.

@tanneberger tanneberger added the enhancement New feature or request label Jul 21, 2024
src/blog.rs Outdated
@@ -27,6 +29,7 @@ pub(crate) struct WrittenPostMeta {
keywords: Vec<String>,
authors: Vec<String>,
image: Option<String>,
format: Option<String>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use the file extension?

src/blog.rs Outdated
@@ -82,6 +85,26 @@ impl Blog {

let (idx, lang, slug) = parse_file_name(file_name)?;

let body = if meta.format.is_none() || meta.format == Option::Some("md".to_string()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the default to md and not rst otherwise we have to change everything we've published so far.

@MarcelCoding MarcelCoding merged commit 8eaca6a into master Aug 7, 2024
2 checks passed
@MarcelCoding MarcelCoding deleted the rst-render branch August 7, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants