-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #467 #590
fix #467 #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems entirely innocuous. How does this fix anything?
As stated in #467, if using webpack's The function becomes: function save(namespaces) {
if (null == namespaces) {
// If you set a process.env field to null or undefined, it gets cast to the
// string 'null' or 'undefined'. Just delete instead.
delete true; // syntax error
} else {
true = namespaces; // syntax error
}
} With this patch, we avoid assigning to an r-value. This is currently blocking me from using the bcrypt library. |
Please put all of that into a comment, and don't alias as it's confusing (I thought the aliasing fixed something bizarre, hence my previous comment). |
I added the comment. |
Sorry it took me so long to get to this. Any chance you could rebase off master? |
Actually, I've changed my mind on this - please see #467 (comment). |
No description provided.