You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following deislabs#47 here, let's rename the annotation used to inject the proxy in the pods:
- previous annotation key: `osiris.deislabs.io/enabled`
- new annotation key: `osiris.deislabs.io/injectProxy`
so that we can avoid confusion between the deployments and pods annotations
@vbehar I'm wondering about maybe using an annotation that references purpose more than implementation. What about osiris.deislabs.io/collectMetrics? That doesn't say how the metrics are collected and doesn't invite users to concern themselves with that detail.
@vbehar thanks for updating this to osiris.deislabs.io/collectMetrics. I think the original, ambiguous osiris.deislabs.io/enabled still appears on deployment and service resources. I'm thinking they deserve the same treatment as part of this PR. Something like osiris.deislabs.io/manageEndpoints for service resources and something like osiris.deislabs.io/enableScaling for deployments.
vbehar
added a commit
to dailymotion-oss/osiris
that referenced
this pull request
Sep 14, 2020
see deislabs#49 (comment)
no more `osiris.xxx/enabled` annotation, it's been replaced by:
- `osiris.xxx/collectMetrics` for the pods
- `osiris.xxx/enableScaling` for the workloads (deployments/statefulsets)
- `osiris.xxx/manageEndpoints` for the services
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #47 here, let's rename the annotation used to inject the proxy in the pods:
osiris.deislabs.io/enabled
osiris.deislabs.io/injectProxy
so that we can avoid confusion between the deployments and pods annotations