scale down share preview thumbnail more memory efficiently #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
approved these changes
Apr 12, 2022
| // Should include kCGImageSourceCreateThumbnailWithTransform: true in the options dictionary. Otherwise, the image result will appear rotated when an image is taken from camera in the portrait orientation. | ||
| kCGImageSourceCreateThumbnailWithTransform: true | ||
| ] | ||
| scaledImage = CGImageSourceCreateThumbnailAtIndex(imageSource, 0, options as CFDictionary) |
There was a problem hiding this comment.
does this function create a physical file? saveImage saves in the .documentDirectory - so that thumbnail would be user-visible?
There was a problem hiding this comment.
No, not this line but earlier in ImageFormat.save(...). That was there before and fixing it is a little bit complicated which is why I didn't add the fix to the other image-cleanup-PR .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1521
However even larger images (~7mb) cannot be sent due to the inefficient way the core scales down images, see deltachat/deltachat-core-rust#2681