refactor: Default to import JSR instead of GitHub URL #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more convienient if you use Typefetch in a package that is going to be published on JSR. If you don't want to make it the default, can you add the exports? :) Signed-off-by: Tim Hårek Andreassen <[email protected]>
|
I wanted to and still want to do this, it's just that JSR doesn't support augmenting global types at the moment, see denoland/deno#23427 and jsr-io/jsr#339 This PR does everything it needs to, so all we can do is really wait for those issues to be resolved and push for the deno team to fix them. |
|
Aha! I wasn't aware of that, I'll close the PR then 😊 Thanks for the quick reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more convienient if you use Typefetch in a package that is
going to be published on JSR.
If you don't want to make it the default, can you add the exports? :)