fix(eslint): handle monorepo setup for eslint #4637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heuristic for finding the correct Cwd when executing eslint does not work in the context of a monorepo setup where the `.eslintrc.js` may not live in the root of the repo but in one of the leaf packages ie. each package may have its own settings. This PR fixes the behaviour by setting Cwd to the closest config path instead of the bin path.
|
I'll have a think about this. ESLint keeps changing over the years and this change could break something. |
|
This looks like the correct behaviour to me. You'll have to fix the tests. See |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heuristic for finding the correct Cwd when executing eslint does not work in the context of a monorepo setup where the
.eslintrc.jsmay not live in the root of the repo but in one of the leaf packages ie. each package may have its own settings.This PR fixes the behaviour by setting Cwd to the closest config path instead of the bin path.
Fixes #4487