Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow both .yaml and .yml for skin #2284

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Allow both .yaml and .yml for skin #2284

merged 1 commit into from
Nov 26, 2023

Conversation

placintaalexandru
Copy link
Contributor

@wjiec
Copy link
Contributor

wjiec commented Nov 10, 2023

I think we could apply this to views.yml and config.yml, or any other yaml configuration file? 🤔️

@placintaalexandru
Copy link
Contributor Author

placintaalexandru commented Nov 10, 2023 •
edited
Loading

I was thinking about this.

  • I'll add it

@derailed derailed added enhancement New feature or request question Further information is requested needs-tlc Pr needs additional updates labels Nov 12, 2023
@placintaalexandru placintaalexandru force-pushed the Use-either-extension-.yaml-or-.yml branch 3 times, most recently from 22b8edb to df9a034 Compare November 13, 2023 10:17
derailed
derailed requested changes Nov 21, 2023
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@placintaalexandru Nice work! Thank you for this nice update Alexandru!!
Just a few small picks...
Also there is an existing helper isYamlFile (may need some TLC) but we could leverage and reuse it here see (config/plugin.go). Thank you!!

internal/config/config.go Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
@derailed derailed added change-requested PR requires updates and removed question Further information is requested needs-tlc Pr needs additional updates labels Nov 21, 2023
@placintaalexandru
Copy link
Contributor Author

@placintaalexandru Nice work! Thank you for this nice update Alexandru!! Just a few small picks... Also there is an existing helper isYamlFile (may need some TLC) but we could leverage and reuse it here see (config/plugin.go). Thank you!!

I saw isYamlFile, but it does not help me in this case

@placintaalexandru placintaalexandru force-pushed the Use-either-extension-.yaml-or-.yml branch from df9a034 to 985457c Compare November 21, 2023 20:14
derailed
derailed approved these changes Nov 26, 2023
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@placintaalexandru Thank you for the updates!

@derailed derailed merged commit 38275b2 into derailed:master Nov 26, 2023
1 check passed
@placintaalexandru placintaalexandru deleted the Use-either-extension-.yaml-or-.yml branch November 26, 2023 15:16
@derailed derailed mentioned this pull request Dec 7, 2023
Merged
thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this pull request Feb 23, 2024
@placintaalexandru @thejoeejoee
Allow both .yaml and .yml yaml config files (derailed#2284)
8282891
placintaalexandru added a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
@placintaalexandru
Allow both .yaml and .yml yaml config files (derailed#2284)
17ab198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
change-requested PR requires updates enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@placintaalexandru @wjiec @derailed