-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying path for storing cookies #547
Open
kasatani
wants to merge
3
commits into
detro:master
Choose a base branch
from
kasatani:cookiejar-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
test/java/src/test/java/ghostdriver/CookieStoreTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
/* | ||
This file is part of the GhostDriver by Ivan De Marino <http://ivandemarino.me>. | ||
|
||
Copyright (c) 2017, Jason Gowan | ||
Copyright (c) 2012-2014, Ivan De Marino <http://ivandemarino.me> | ||
All rights reserved. | ||
|
||
Redistribution and use in source and binary forms, with or without modification, | ||
are permitted provided that the following conditions are met: | ||
|
||
* Redistributions of source code must retain the above copyright notice, | ||
this list of conditions and the following disclaimer. | ||
* Redistributions in binary form must reproduce the above copyright notice, | ||
this list of conditions and the following disclaimer in the documentation | ||
and/or other materials provided with the distribution. | ||
|
||
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND | ||
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED | ||
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR | ||
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON | ||
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
package ghostdriver; | ||
|
||
import static org.junit.Assert.*; | ||
|
||
import org.junit.After; | ||
import org.junit.Test; | ||
import org.openqa.selenium.By; | ||
import org.openqa.selenium.WebElement; | ||
|
||
import ghostdriver.server.HttpRequestCallback; | ||
|
||
import javax.servlet.http.Cookie; | ||
import javax.servlet.http.HttpServletRequest; | ||
import javax.servlet.http.HttpServletResponse; | ||
import java.io.*; | ||
import java.text.SimpleDateFormat; | ||
import java.util.Date; | ||
|
||
public class CookieStoreTest extends BaseTestWithServer { | ||
private File cookiesFile; | ||
|
||
private final static HttpRequestCallback COOKIE_TEST_CALLBACK = new HttpRequestCallback() { | ||
@Override | ||
public void call(HttpServletRequest req, HttpServletResponse res) throws IOException { | ||
javax.servlet.http.Cookie cookie = new javax.servlet.http.Cookie("test", "test"); | ||
cookie.setDomain(".localhost"); | ||
cookie.setMaxAge(360); | ||
|
||
res.addCookie(cookie); | ||
|
||
Cookie[] requestCookies = req.getCookies(); | ||
String value = ""; | ||
for (int i = 0; i < requestCookies.length; i++) { | ||
if (requestCookies[i].getName().equals("hello")) { | ||
value = requestCookies[i].getValue().replaceAll("[^a-z]", ""); | ||
} | ||
} | ||
res.getOutputStream().println("<div id=\"hello\">" + value + "</div>"); | ||
} | ||
}; | ||
|
||
private void goToPage(String path) { | ||
getDriver().get(server.getBaseUrl() + path); | ||
} | ||
|
||
private void goToPage() { | ||
goToPage(""); | ||
} | ||
|
||
@Override | ||
public void prepareDriver() throws Exception { | ||
cookiesFile = File.createTempFile("cookies", ".ini"); | ||
FileWriter writer = new FileWriter(cookiesFile); | ||
String expires = new SimpleDateFormat("EEE, dd-MMM-yyyy HH:mm:ss zzz"). | ||
format(new Date(System.currentTimeMillis() + 3600 * 1000)); | ||
writer.write("[General]\n"); | ||
writer.write("cookies=\"@Variant(\\0\\0\\0\\x7f\\0\\0\\0\\x16QList<QNetworkCookie>" + | ||
"\\0\\0\\0\\0\\x1\\0\\0\\0\\x1\\0\\0\\0Mhello=world; expires=" + expires + | ||
"; domain=.localhost; path=/)\"\n"); | ||
writer.close(); | ||
sCaps.setCapability("phantomjs.cookies.path", cookiesFile.getPath()); | ||
super.prepareDriver(); | ||
} | ||
|
||
@After | ||
public void deleteCookiesFile() throws IOException { | ||
cookiesFile.delete(); | ||
} | ||
|
||
@Test | ||
public void shouldSaveCookies() throws Exception { | ||
disableAutoQuitDriver(); | ||
server.setHttpHandler("GET", COOKIE_TEST_CALLBACK); | ||
goToPage(); | ||
getDriver().quit(); | ||
|
||
BufferedReader reader = new BufferedReader(new FileReader(cookiesFile)); | ||
boolean matched = false; | ||
String line; | ||
while ((line = reader.readLine()) != null) { | ||
if (line.indexOf("test=test") >= 0) matched = true; | ||
} | ||
assertTrue(matched); | ||
} | ||
|
||
@Test | ||
public void shouldLoadCookies() throws Exception { | ||
server.setHttpHandler("GET", COOKIE_TEST_CALLBACK); | ||
goToPage(); | ||
WebElement e = getDriver().findElement(By.id("hello")); | ||
assertEquals("world", e.getText()); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default should be an empty string to be consistent with the phantomjs source. though i'd prefer to be conservative and pass no arguments when this option is not used.