Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the name in the generated
package.json
iscql2-wasm
. I'd like to get the opinion of frontend folk on whether that's fine, or whether we should make sure it's calledcql2
. I don't see an easy way to set the project name (I did some cursory digging which turned up rustwasm/wasm-pack#840 and rustwasm/wasm-pack#427 w/o a clear answer), so if we do want to name thingscql2
(without manually editing thepackage.json
every time) we may have to try to move the WASM crate into the main crate and feature-flag it.